History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: WIRED-288
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Mark Donszelmann
Reporter: Jan Strube
Votes: 0
Watchers: 0
Operations

Clone this issue
Create sub-task
If you were logged in you would be able to see more operations.
WIRED

opening MCTracks subcategory results in all items being checked

Created: 05/Jun/04 04:54 PM   Updated: 06/Aug/05 02:32 PM
Component/s: None
Affects Version/s: 4.0.alpha.3
Fix Version/s: 4.0.rc.1

File Attachments: None
Image Attachments:

1. wiredTreeView.png
(3 kb)
Environment: Win XP, whichever version of WIRED3 comes default with Jas3 0.7.5
Issue Links:
Needs
 
See also


 Description  « Hide
In the WIRED3 event display, opening McTrack gives me a list, charged and neutral.
Unchecking both categories and opening either of them gives me a list with all items checked, although the event display is still empty.
Unchecking one of them results in all other items being displayed.

When the parent is unchecked, all children should inherit this state upon opening the list.

 All   Comments   Change History      Sort Order:
Mark Donszelmann - 08/Jun/04 01:24 AM
I am afraid the WIRED 3 Tree has become quite complicated, and we may not want to go back and fix this.

We are looking into an easier Tree for WIRED 4.

Jan Strube - 06/Aug/05 01:10 PM
I am testing in jas-0.8.1 with WIRED 4.0.
This issue should not be marked resolved. Please look at the attached image

Jan Strube - 06/Aug/05 01:12 PM
As you can see, the Top level item is unmarked, while the children are still marked.
(The WIRED view was updated correctly, removing _all_ child items)

Mark Donszelmann - 06/Aug/05 01:34 PM
Hi Jan,

am I right that the detector is invisible when you see this tree? If so, that is correct.
The items below DetectorType will not be shown, since the "folder" checkbox
is off. The rest of the selection stays as is.

The view drawn from this tree will skip the full DetectorType tree.

If you switch DetectorTree on, all elements below will show. If no elements are on,
then all children will be switched on (in this case Barrel and Endcap) because
otherwise the switching of DetectorTree does not have any result.

At this moment there will be some (all) elements shown, so no further switches
are made.

Let me know if it does not do what you expect ?

Mark Donszelmann - 06/Aug/05 01:39 PM
Hi again,

just checked. It does not switch back on the Barrel and Endcap. It does switch on the "file" checkbox of DetectorType
since both Barrel and EndCap folders are off.

Maybe we can improve on this behaviour.

Regards
Mark

Jan Strube - 06/Aug/05 01:49 PM
Hi Mark,

The current behavior does follow a certain logic, but it is unexpected at best
What (I think) it does now:
Unmarking the parent Item (like Detector) removes _all_ detector parts from the WIRED display
BUT: It leaves the children marked. When clicking on a child and thereby _unmarking_ it, all detector parts except the unmarked one re-appear on the display.

What I would expect:
Unmarking an item removes it from the screen and unmarks all children.

Thus, when I want to select only tracks, what I would like to do is:
Unmark "Event Type"
Mark Tracks.

What I have to do now:
Unmark Event Type and _all children_
mark Tracks

This is really complicated to explain, but I think the issue is pretty simple to solve.
Thanks for looking into this.
Cheers,
Jan

Mark Donszelmann - 06/Aug/05 02:17 PM
Ok, here is how it was designed:

- every leaf node has one checkbox.
- every branch node has 2 checkboxes, one for any drawable items directly attached to the branch, and one that switches all the children.

Checking any of the leaf node switches and branch node (right switch) will change the visibility of that nodes drawable items. If
that change will NOT result in a change in the view, we go up the tree and make sure its parents (folder switches) are on.

Checking any of the branch switches (left switch) will switch on/off a full tree below, BUT will not change any setting below.
Reason for this is to make sure you can quickly switch off a full tree and switch it on again, preserving any of the settings
below (these hits on, these hits off, ...)

To explicitly change the state below a node, use the popup menu "Show all", "Hide all" etc.

There are still 2 problems with this:
1. WIRED-326, if a branch node has no real visible items attached to it, it should not show the second checkbox.
2. WIRED-460, revalidate/repaint of the tree when using the popup menu does not always work.


Jan Strube - 06/Aug/05 02:32 PM
Hi Mark,
this is interesting.

> Checking any of the branch switches (left switch) will switch on/off a full tree below, BUT will not change any setting below.
> Reason for this is to make sure you can quickly switch off a full tree and switch it on again, preserving any of the settings
> below (these hits on, these hits off, ...)

This is different from all other applications I know. I can see the reasoning behind this, but find it illogical. The expected behavior is:
Everything that's marked is actually drawn. Everything that's not marked is not drawn.
I am not used to a tree view having a context menu.

So, I guess it works as intended, but not as I would expect.

I personally would change this behavior, but if you don't intend to do so, you can mark this bug as resolved from my point of view.
Cheers,
Jan